add resource command #170
Merged
add resource command #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Address #152 |
chenk008
reviewed
Mar 7, 2022
chenk008
reviewed
Mar 7, 2022
|
@chenk008 Can you help double check and approve the change? |
chenk008
pushed a commit
that referenced
this pull request
Mar 22, 2022
* auto fill resource information into command Co-authored-by: zhuang <zhengchicheng.zcc@alibaba-inc.com>
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* auto fill resource information into command Co-authored-by: zhuang <zhengchicheng.zcc@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Using container.resource.cpu.limit as num-cpus default value in rayStartParams, it will help to reduce configuration redundancy. When we want to change the container resource config, we don't need to update rayStartParams.
It's the same with memory,gpu.
Related issue number
Checks