Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce batch.jobs rules for multiple namespace role #1707

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

riccardomc
Copy link
Contributor

@riccardomc riccardomc commented Dec 4, 2023

Why are these changes needed?

This PR introduces rules to fix issue #1706, i.e. KubeRay Operator is not able to do operations on Jobs when installed "namespaced".

Related issue number

Closes #1706

Can confirm on a local installation that this addition fixes the issue.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 self-assigned this Dec 4, 2023
@kevin85421 kevin85421 self-requested a review December 4, 2023 18:17
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I will manual test it before I merge this PR.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this PR manually.

  • Without this PR:
    Screen Shot 2023-12-05 at 1 53 31 PM

  • With this PR:
    Screen Shot 2023-12-05 at 1 49 57 PM

@kevin85421 kevin85421 merged commit 1779fcd into ray-project:master Dec 5, 2023
25 checks passed
blublinsky pushed a commit to blublinsky/kuberay that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] KubeRay operator Role missing 'batch' API Group rules
2 participants