Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set imagePullPolicy in manager.yaml #1710

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

evalaiyc98
Copy link
Contributor

Why are these changes needed?

Noticed that using make deploy command to deploy kuberay operator, it will use the default image tag :latest to build the operator.
In Kubernetes documentation, it said that

If don't specify a registry hostname, Kubernetes assumes that you mean the Docker public registry.

If omit the imagePullPolicy field, and the tag for the container image is :latest, imagePullPolicy is automatically set to Always.

To avoid the failure of pulling an image from a remote repository that does not exist, there should specify the imagePullPolicy.

Without this PR, there would be an error when deploying the kuberay operator.

error_pull

With this PR, the process of deploying the kuberay operator is quick fast because can use the image which is already on the machine.

describe pod

success

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 self-assigned this Dec 5, 2023
@kevin85421 kevin85421 merged commit 4c2c046 into ray-project:master Dec 5, 2023
25 checks passed
@evalaiyc98 evalaiyc98 deleted the image-policy branch December 6, 2023 08:08
blublinsky pushed a commit to blublinsky/kuberay that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants