Publish Multi Arch images #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Greaaaaat! Just leave a minor comment. By the way, would you mind adding some instructions in DEVELOPMENT.md about how to build multi-arch images locally? Thanks!
.github/workflows/test-job.yaml
Outdated
| docker image tag kuberay/operator:${{ steps.vars.outputs.sha_short }} quay.io/kuberay/operator:nightly; | ||
| docker push quay.io/kuberay/operator:nightly | ||
| if: contains(fromJson('["refs/heads/master"]'), github.ref) | ||
| CGO_ENABLED=1 GOOS=linux GOARCH=$GOARCH go build -tags strictfipsruntime -a -o manager-$GOARCH main.go |
There was a problem hiding this comment.
nit: Why do we use CGO_ENABLED=1 instead of CGO_ENABLED=$CGO_ENABLED?
| context: ${{env.working-directory}} | ||
| file: ${{env.working-directory}}/Dockerfile.buildx | ||
| push: ${{env.PUSH}} | ||
| provenance: false |
tedhtchang
force-pushed
the
Build-multiArch-docker
branch
from
9c473f2
to
0ddc132
Compare
kevin85421
approved these changes
Dec 8, 2023
|
Nice! 
|
This was referenced Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #1630
Related issue number
Closes #1630
Checks