Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed JobSubmission API #1717

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

blublinsky
Copy link
Contributor

@blublinsky blublinsky commented Dec 6, 2023

Why are these changes needed?

fixes job submission apis for non-existing submission id

Related issue number

closes #1714

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [x ] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@kevin85421, this fixes #1714. PLease merge

@kevin85421
Copy link
Member

cc @z103cb @astefanutti @tedhtchang would you mind reviewing this PR? Thanks!

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit f109594 into ray-project:master Dec 6, 2023
24 checks passed
blublinsky added a commit to blublinsky/kuberay that referenced this pull request Dec 6, 2023
@blublinsky blublinsky deleted the JobSubmission-API branch December 7, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [API Server] JobSubmission API returns 502 on jobs that do not exist
3 participants