[Feature] Override the block option of rayStartParams to true
#1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
LGTM!
@kevin85421, should we add a warning message in the validation webhook to inform users when their block value is overridden?
This will be great. We can update the validation webhook in the follow up PR.
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Dec 6, 2023
rueian
added a commit
to rueian/kuberay
that referenced
this pull request
Dec 6, 2023
…true (ray-project#1718)" This reverts commit c552d3c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the #932, we continue to enforce the
--blockoption in the ray start command. Previously, we only injected the--blockoption when it was missing in therayStartParams. Now, we override it to betrueanyway and we don't need to injectsleep infinityanymore.@kevin85421, should we add a warning message in the validation webhook to inform users when their
blockvalue is overridden?