[RayJob][Status][1/n] Redefine the definition of JobDeploymentStatusComplete

[kevin85421]

Why are these changes needed?

if isJobSucceedOrFailed(rayJobInstance.Status.JobStatus) && rayJobInstance.Status.JobDeploymentStatus != rayv1.JobDeploymentStatusComplete {
  ...
}

The check of JobDeploymentStatusComplete is not necessary because there is a check to skip the reconciliation if the status is rayv1.JobDeploymentStatusComplete.

• kuberay/ray-operator/controllers/ray/rayjob_controller.go

  Lines 124 to 128 in b16c705

  	// Do not reconcile the RayJob if the deployment status is marked as Complete
  	if rayJobInstance.Status.JobDeploymentStatus == rayv1.JobDeploymentStatusComplete {
  	r.Log.Info("rayjob is complete, skip reconciliation", "rayjob", rayJobInstance.Name)
  	return ctrl.Result{}, nil
  	}

Related issue number

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[architkulkarni]

Nice!