[RayJob][Status][3/n] Define JobDeploymentStatusInitializing #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Dec 12, 2023
| @@ -35,8 +35,6 @@ type JobDeploymentStatus string | |||
| const ( | |||
| JobDeploymentStatusInitializing JobDeploymentStatus = "Initializing" | |||
| JobDeploymentStatusFailedToGetOrCreateRayCluster JobDeploymentStatus = "FailedToGetOrCreateRayCluster" | |||
| JobDeploymentStatusWaitForDashboard JobDeploymentStatus = "WaitForDashboard" | |||
There was a problem hiding this comment.
I forgot to update v1alpha1 in #1733.
kevin85421
changed the title
architkulkarni
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR doesn’t change any code logic. Most of the work was done by #1733.
initRayJobStatusIfNeedis the source of truth whereJobDeploymentStatusInitializingis defined.JobDeploymentStatusInitializingmeans thatJobID,JobStatus, andRayClusterNameare initialized, so double creations of RayCluster CRs andray jobwill not happen.JobDeploymentStatusInitializingimplies that the RayJob is ready to create or get RayCluster CR.Related issue number
Checks