Check existing pods for suspended RayCluster before calling DeleteCollection #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
commented
Dec 13, 2023
| @@ -585,6 +585,15 @@ func (r *RayClusterReconciler) reconcilePods(ctx context.Context, instance *rayv | |||
| // if RayCluster is suspended, delete all pods and skip reconcile | |||
| if instance.Spec.Suspend != nil && *instance.Spec.Suspend { | |||
| clusterLabel := client.MatchingLabels{utils.RayClusterLabelKey: instance.Name} | |||
| allPods := corev1.PodList{} | |||
| if err := r.List(ctx, &allPods, client.InNamespace(instance.Namespace), clusterLabel); err != nil { | |||
There was a problem hiding this comment.
I'm not super familiar with controller-runtime's client, but I'm guessing this is a list from the informer cache, which is better than always calling DeleteCollection below.
There was a problem hiding this comment.
I'm guessing this is a list from the informer cache
Yes, in KubeRay's setup, the List operation reads from the informer cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow-up to #1711 & #1741.
After #1741, we always run the reconcile loop for suspended RayCluster, regardless of it's state. This means that for suspended clusters we will always call DeleteCollection and record an event.
This PR makes a small optimization to check existing pods before calling DeleteCollection. This should not be susceptible to the same bug fixed in #1741 since we are not checking cluster state, but rather checking informer cache for existing pods.
Related issue number
#1667
Checks