Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Clean up WorkersToDelete after the scaling process finishes #1747

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Dec 13, 2023

Why are these changes needed?

  • Delete "should update a raycluster object deleting a random pod".

  • The test "simulate Ray Autoscaler scales down" simulates the Ray Autoscaler's behavior to scale down the RayCluster by updating WorkersToDelete. However, we don't clean up the WorkersToDelete after the scaling process finishes.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review December 13, 2023 21:41
@kevin85421 kevin85421 merged commit f56c66f into ray-project:master Dec 13, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants