[RayJob][Status][5/n] Refactor getOrCreateK8sJob #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Dec 14, 2023
|
|
||
| // Check the status of the k8s job and update the RayJobInstance status accordingly. | ||
| // Get the k8s job | ||
| k8sJob := &batchv1.Job{} |
There was a problem hiding this comment.
We don't need to Get the K8s Job again because getOrCreateK8sJob has already performed this check.
kevin85421
commented
Dec 14, 2023
| return ctrl.Result{RequeueAfter: RayJobDefaultRequeueDuration}, err | ||
| } | ||
|
|
||
| if wasJobCreated { |
There was a problem hiding this comment.
Print the messages immediately after the job is created instead.
kevin85421
commented
Dec 14, 2023
| @@ -262,17 +241,16 @@ func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request) | |||
| // the RayJob is submitted against the RayCluster created by THIS job, then | |||
| // try to gracefully stop the Ray job and delete (suspend) the cluster | |||
| if rayJobInstance.Spec.Suspend && len(rayJobInstance.Spec.ClusterSelector) == 0 { | |||
| info, err := rayDashboardClient.GetJobInfo(ctx, rayJobInstance.Status.JobId) | |||
There was a problem hiding this comment.
We don't need to have an additional GetJobInfo.
kevin85421
commented
Dec 14, 2023
kevin85421
commented
Dec 14, 2023
kevin85421
commented
Dec 14, 2023
kevin85421
force-pushed
the
refactor-getOrCreateK8sJob
branch
from
e7a9ec6
to
fde6271
Compare
Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks