[Bug][RayJob] Avoid nil pointer dereference #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Dec 15, 2023
| @@ -271,9 +266,6 @@ func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request) | |||
| return ctrl.Result{RequeueAfter: RayJobDefaultRequeueDuration}, nil | |||
| // Job may takes long time to start and finish, let's just periodically requeue the job and check status. | |||
| } | |||
| if isJobPendingOrRunning(jobInfo.JobStatus) { | |||
There was a problem hiding this comment.
This is redundant. You can check L269 to L300 with this PR.
kevin85421
commented
Dec 15, 2023
| @@ -301,8 +293,9 @@ func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request) | |||
| } | |||
|
|
|||
| // TODO (kevin85421): Use the source of truth `jobInfo.JobStatus` instead. | |||
| if isJobPendingOrRunning(rayJobInstance.Status.JobStatus) { | |||
| if isJobPendingOrRunning(jobInfo.JobStatus) { | |||
There was a problem hiding this comment.
jobInfo is the source of truth.
kevin85421
commented
Dec 15, 2023
| // This does the right thing, but breaks E2E test | ||
| // return nil, errors.NewBadRequest("Job " + jobId + " does not exist on the cluster") | ||
| return nil, nil | ||
| return nil, errors.NewBadRequest("Job " + jobId + " does not exist on the cluster") |
There was a problem hiding this comment.
Avoid RayJobInfo and error being nil at the same time.
architkulkarni
approved these changes
Dec 15, 2023
|
Update the PR description. Merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Reproduce the error:
backoffLimitbefore the new head Pod is ready, the KubeRay operator will fail after the head Pod is restored. This failure occurs because if the job is not found, bothjobInfoanderrorwill return asnil. Consequently, at L274,isJobPendingOrRunning(jobInfo.JobStatus)will attempt to dereference anilpointer.[1] To easily reproduce the issue, I recommend using the nightly image, as its
backoffLimitis smaller than that of v1.0.0. Hence, "the submitter Pod reaches thebackoffLimitbefore the new head Pod is ready" is more likely to happen.Related issue number
Checks
With this PR, the operator will throw an exception instead of crashing.