Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Adding RAY_CLOUD_INSTANCE_ID as unique id for Ray node #1759

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[Feature] Adding RAY_CLOUD_INSTANCE_ID as unique id for Ray node #1759

merged 1 commit into from
Dec 20, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Dec 20, 2023 •
edited

Why are these changes needed?

Related issue number

Closes #1751

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
Screen Shot 2023-12-19 at 11 11 21 PM Screen Shot 2023-12-19 at 11 11 52 PM

@kevin85421 kevin85421 marked this pull request as ready for review December 20, 2023 07:27
rickyyx
rickyyx approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@rickyyx
Copy link
Contributor

rickyyx commented Dec 20, 2023

Is below part of the env var value or it's just the key reference that was shown together?
image

@kevin85421
Copy link
Member Author

Is below part of the env var value or it's just the key reference that was shown together?

It is just a reference to the Pod's metadata.name.

@kevin85421 kevin85421 merged commit e11a9b7 into ray-project:master Dec 20, 2023
25 checks passed
@kevin85421 kevin85421 mentioned this pull request Jan 26, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees

@architkulkarni architkulkarni

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Adding RAY_CLOUD_INSTANCE_ID as unique id for Ray node
3 participants
@kevin85421 @rickyyx @architkulkarni