Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to e2e test, adding Autoscaling #1765

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

Cleaning up existing e2e tests
Adding e2e autoscaling test

Related issue number

Checks

  • [x ] I've made sure the tests are passing.
  • Testing Strategy
    • [ x] Unit tests
    • e2e tests
    • Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@z103cb , @tedhtchang

cc @kevin85421

@blublinsky blublinsky force-pushed the e2e-tests branch 2 times, most recently from 3213f7a to 152e76c Compare January 6, 2024 12:50
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small nitpicks around comments in code this is PR is LGTM.

apiserver/test/e2e/cluster_server_e2e_test.go Outdated Show resolved Hide resolved
apiserver/test/e2e/cluster_server_e2e_test.go Outdated Show resolved Hide resolved
@blublinsky
Copy link
Contributor Author

@kevin85421 its all yours, ready to commit

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is only for KubeRay API server. Stamp.

@kevin85421 kevin85421 merged commit efed875 into ray-project:master Jan 9, 2024
22 of 23 checks passed
@blublinsky blublinsky deleted the e2e-tests branch January 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants