[RayJob][Status][8/n] Only a RayJob with the status Running can transition to Complete at this moment #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
force-pushed
the
rayjob-running-1
branch
from
588d1ae
to
f90ba55
Compare
kevin85421
changed the title
architkulkarni
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, only a RayJob with the status
JobDeploymentStatusRunningcan transition toJobDeploymentStatusCompletein the current state machine. In the future, there might be other conditions under which a RayJob transitions toJobDeploymentStatusCompletefrom other statuses. For example, if a RayJob fails to submit Ray jobs several times, we may consider transitioning its status toJobDeploymentStatusComplete. However, only the transition from Running will checkJobStatus.Related issue number
Checks