[CI] Fix variable initializations used in test case declarations #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review this PR after #1770 gets merged. |
|
Would you mind rebasing with the master branch? Thanks! |
rueian
force-pushed
the
fix-compatibility-env
branch
from
cca0147
to
786b5c3
Compare
kevin85421
reviewed
Dec 29, 2023
tests/compatibility-test.py
Outdated
| @@ -150,18 +153,15 @@ def test_ray_serve(self): | |||
| show_cluster_info(RayFTTestCase.ray_cluster_ns) | |||
| self.fail(f"Fail to execute test_ray_serve_2.py. The exit code is {exit_code}.") | |||
|
|
|||
| @unittest.skipIf( | |||
| ray_version == '2.8.0' or ray_version == 'nightly', | |||
There was a problem hiding this comment.
Why do we need to skip nightly?
There was a problem hiding this comment.
Thanks. That was a mistake. We don’t need to skip nightly anymore.
tests/compatibility-test.py
Outdated
| @@ -150,18 +153,15 @@ def test_ray_serve(self): | |||
| show_cluster_info(RayFTTestCase.ray_cluster_ns) | |||
| self.fail(f"Fail to execute test_ray_serve_2.py. The exit code is {exit_code}.") | |||
|
|
|||
| @unittest.skipIf( | |||
| ray_version == '2.8.0' or ray_version == 'nightly', | |||
| 'test_detached_actor is too flaky with Ray 2.8.0 due to' | |||
There was a problem hiding this comment.
Suggested change
| 'test_detached_actor is too flaky with Ray 2.8.0 due to' | |
| 'test_detached_actor is too flaky with Ray 2.8.0 due to ' |
tests/compatibility-test.py
Outdated
| @unittest.skipIf( | ||
| ray_version == '2.8.0' or ray_version == 'nightly', | ||
| 'test_detached_actor is too flaky with Ray 2.8.0 due to' | ||
| 'https://github.com/ray-project/ray/issues/41343.' |
There was a problem hiding this comment.
Suggested change
| 'https://github.com/ray-project/ray/issues/41343.' | |
| 'https://github.com/ray-project/ray/issues/41343. ' |
Signed-off-by: Rueian <rueiancsie@gmail.com>
kevin85421
approved these changes
Dec 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These global variables
ray_image,ray_version, andkuberay_operator_imageare heavily used in test case declarations. But currently, their value will be changed in theif __name__ == '__main__'block which runs after test case declarations.Therefore, it causes undesired evaluations in some cases, such as
kuberay/tests/compatibility-test.py
Lines 153 to 154 in 59503c6
where it always evaluates the
ray_versionto the initial default value, instead of the value we inject via the env later.See more details: #1770 (comment)
This PR fixes their values at the beginning of the test script and does not change them after initialization.
Related issue number
#1773
Checks