[RayJob][Status][11/n] Refactor the suspend operation #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
changed the title
architkulkarni
approved these changes
Dec 28, 2023
| @@ -164,7 +174,7 @@ func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request) | |||
| return ctrl.Result{RequeueAfter: time.Duration(delta) * time.Second}, nil | |||
| } else { | |||
| if err = r.releaseComputeResources(ctx, rayJobInstance); err != nil { | |||
| return ctrl.Result{RequeueAfter: RayJobDefaultRequeueDuration}, nil | |||
| return ctrl.Result{RequeueAfter: RayJobDefaultRequeueDuration}, err | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RunningandInitializingallows transitioning toSuspended. This PR adds a test to ensure there is no state transition fromCompletetoSuspended.suspendto false:Status.RayClusterNameis empty.SuspendedtoNew. Consequently, the RayCluster will be created upon resumption. However, there is still an issue with the submitter Job. If users don't setshutDownAfterFinishes, the submitter Job will become Complete after suspension. When we resume the RayJob, a new Kubernetes Job will not be created because one already exists. This is a follow-up issue.Related issue number
Checks