Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayService] Unify multi-app and single-app codepath #1787

Merged
merged 2 commits into from
Dec 29, 2023
Merged

[RayService] Unify multi-app and single-app codepath #1787

merged 2 commits into from
Dec 29, 2023

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Dec 29, 2023 •
edited

Why are these changes needed?

Followup to #1779 (review).

  • Deletes the SINGLE_APP and MULTI_APP codepaths and unifies them into one codepath.
  • Deletes unused dashboard function GetDeployments

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@architkulkarni
Unify multi-app and single-app codepath
b53b536 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
@architkulkarni architkulkarni mentioned this pull request Dec 29, 2023
Closed
4 tasks
@architkulkarni
Update ray-operator/controllers/ray/utils/serve_api_models.go
25431e1 
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
kevin85421
kevin85421 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin85421 kevin85421 self-assigned this Dec 29, 2023
@kevin85421 kevin85421 merged commit 7fd79f8 into ray-project:master Dec 29, 2023
7 checks passed
@kevin85421 kevin85421 mentioned this pull request Jan 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@architkulkarni @kevin85421