[Test][RayJob] Kueue happy-path scenario #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
commented
Jan 6, 2024
|
|
||
| test.T().Logf("Resume the RayJob by updating `suspend` to false.") | ||
| rayJob.Spec.Suspend = false | ||
| // TODO (kevin85421): We may need to retry `Update` if 409 conflict makes the test flaky. |
There was a problem hiding this comment.
I might use patch instead, as mentioned in this discussion, after I acquire sufficient related knowledge (e.g., server-side apply).
There was a problem hiding this comment.
I've created #1811 that's related to server-side apply.
There was a problem hiding this comment.
Thanks! Would you be interested in contributing to #1811?
There was a problem hiding this comment.
Yes, I should be able to work on it soon.
andrewsykim
approved these changes
Jan 8, 2024
gvspraveen
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR provides an end-to-end test covering the happy-path scenario for Kueue. Specifically, it creates a suspended RayJob with
.spec.suspend = trueat creation time (achieved by Kueue using a webhook), resumes it manually, and checks for successful completion.Related issue number
Closes #1800
Checks