Add NumOfHosts to WorkerGroupSpec (CRD change only) #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
Jan 13, 2024
| @@ -56,6 +56,9 @@ type WorkerGroupSpec struct { | |||
| // MaxReplicas denotes the maximum number of desired Pods for this worker group, and the default value is maxInt32. | |||
| // +kubebuilder:default:=2147483647 | |||
| MaxReplicas *int32 `json:"maxReplicas"` | |||
| // NumOfHosts denotes the number of hosts to create per replica. The default value is 1. | |||
| // +kubebuilder:default:=1 | |||
| NumOfHosts *int32 `json:"numOfHosts"` | |||
There was a problem hiding this comment.
- Should we add
omitemptyto make this field optional? - Perhaps we could use
int32instead to avoid some nil checks.
kevin85421
reviewed
Jan 16, 2024
There was a problem hiding this comment.
You can run make sync to resolve the CI error operator-consistency-check / helm-chart-verify-crd. See this doc for more details.
|
Done, all the tests are passing now. |
kevin85421
approved these changes
Jan 17, 2024
|
Seems like I don't have write access. Can you merge? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds "NumOfHosts" as an int32 field in RayCluster CR's WorkerGroupSpec section. NumOfHosts will be used to denote WorkerGroup replicas consisting of multiple hosts (for example, TPU hosts in a multi-host pod).
Related issue number
ray-project/ray#39781
Checks