[RayService] Deprecate the built-in ingress support of RayService #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Jan 17, 2024
| @@ -907,53 +903,6 @@ func (r *RayServiceReconciler) updateRayClusterInfo(rayServiceInstance *rayv1.Ra | |||
| } | |||
| } | |||
|
|
|||
| // TODO: When start Ingress in RayService, we can disable the Ingress from RayCluster. | |||
| func (r *RayServiceReconciler) reconcileIngress(ctx context.Context, rayServiceInstance *rayv1.RayService, rayClusterInstance *rayv1.RayCluster) error { | |||
| if rayClusterInstance.Spec.HeadGroupSpec.EnableIngress == nil || !*rayClusterInstance.Spec.HeadGroupSpec.EnableIngress { | |||
There was a problem hiding this comment.
Also deprecate the .Spec.HeadGroupSpec.EnableIngress field?
There was a problem hiding this comment.
This is also used by the RayCluster controller. I will deprecate the field if we decide to deprecate the built-in Ingress support of RayCluster.
architkulkarni
approved these changes
Jan 18, 2024
ryanaoleary
pushed a commit
to ryanaoleary/kuberay
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It is highly possible that the built-in ingress support in RayService hasn't been working since the day it was committed.
You can create a RayService with
EnableIngress: truewith this gist. Initially, the RayCluster managed by the RayService will create a Kubernetes Ingress. Once the RayCluster is ready, the RayService controller will attempt to create another ingress. This occurs because both the RayCluster and RayService controllers useHeadGroupSpec.EnableIngressto determine whether to create a Kubernetes Ingress. However, the Ingress created by RayService will fail because of the following reason:Because the RayService reconciler will always get an error from the function
reconcileIngress, the K8s service for Ray Serve will never be created.To reproduce the issue,
EnableIngress: truewith this gistRelated issue number
Checks