Remove generate target from build/test targets #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
|
@astefanutti @kevin85421 thoughts? |
astefanutti
approved these changes
Jan 26, 2024
kevin85421
approved these changes
Jan 29, 2024
kevin85421
approved these changes
Jan 29, 2024
ryanaoleary
pushed a commit
to ryanaoleary/kuberay
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since adding applyconfiguration for generated clients (#1818), code generation has taken longer (~2 mins). We currently run
generatefor the build / test targets and the additional 2 minutes adds up over time.This PR removes the
generatetarget from build/test targets, removing the 2 min delay. I was initially hesitant about removing this target because it would make it easier to forget code generation. However, I think this mostly mitigated by the fact that we have checks to verify generated code.Related issue number
Checks