Refactor to Ensure Consistent Use of CRDType

[Yicheng-Lu-llll]

Why are these changes needed?

This PR ensures consistent use of CRDType instead of string types to avoid potential bugs, addressing the issue described here:

kuberay/ray-operator/controllers/ray/raycluster_controller.go

Line 1059 in 52cb1a1

// TODO (kevin85421): It is better to use `CRDType` as the return type.

Related issue number

Checks

As shown below, we can successfully detect that the RayCluster is created by RayService:

1. The health check is injected into the readiness probe.
2. The RAY_timeout_ms_task_wait_for_death_info environment variable is set.

# Run a Rayservice sample in under https://github.com/ray-project/kuberay/tree/master/ray-operator/config/samples
kubectl apply -f /home/ubuntu/kuberay/ray-operator/config/samples/ray-service.sample.yaml
kubectl get pod
# NAME                                                      READY   STATUS    RESTARTS   AGE
# ervice-sample-raycluster-sdntw-worker-small-group-j7crr   1/1     Running   0          88s
# kuberay-operator-5987588ffc-2cgbf                         1/1     Running   0          2m41s
# rayservice-sample-raycluster-sdntw-head-mp2qb             1/1     Running   0          88s
kubectl describe $(kubectl get pods -o=name | grep worker) | grep  "Readiness:\|Liveness:"
# Liveness:   exec [bash -c wget -T 2 -q -O- http://localhost:52365/api/local_raylet_healthz | grep success] delay=30s timeout=1s period=5s #success=1 #failure=120
# Readiness:  exec [bash -c wget -T 2 -q -O- http://localhost:52365/api/local_raylet_healthz | grep success && wget -T 2 -q -O- http://localhost:8000/-/healthz | grep success] delay=10s timeout=1s period=5s #success=1 #failure=1
kubectl describe $(kubectl get pods -o=name | grep worker) | grep "RAY_timeout_ms_task_wait_for_death_info"
# RAY_timeout_ms_task_wait_for_death_info:  0

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[Yicheng-Lu-llll]

If Labels is nil or does not contain the key, instance.Labels[utils.RayOriginatedFromCRDLabelKey] will return an empty string. See this simple example.

[kevin85421]

nit: Is (aPod corev1.Pod) necessary?

We don't need to update it in this PR. We can revisit all named return values in a separate PR.

[Yicheng-Lu-llll]

I agree aPod is unnecessary.