Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix rebase error #1897

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Feb 2, 2024

Why are these changes needed?

I merged #1894 after all CI tests passed and GitHub reported no conflicts with #1893. However, the rebase mechanism doesn't seem to work well, resulting in CI failures.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review February 2, 2024 00:28
@kevin85421 kevin85421 requested a review from jjyao February 2, 2024 00:34
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp.

@kevin85421 kevin85421 merged commit f1e961a into ray-project:master Feb 2, 2024
23 checks passed
ryanaoleary pushed a commit to ryanaoleary/kuberay that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants