[Feature][RayJob] Support light-weight job submission with entrypoint_num_cpus, entrypoint_num_gpus and entrypoint_resources #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
light-weight-job-continue
branch
from
5926786
to
52bd608
Compare
…_num_cpus, entrypoint_num_gpus and entrypoint_resources
rueian
force-pushed
the
light-weight-job-continue
branch
from
52bd608
to
7e97110
Compare
|
Hi @kevin85421, this PR is ready for review. Could you help review it? Thanks! |
kevin85421
approved these changes
Feb 6, 2024
| @@ -76,12 +82,18 @@ env_vars: | |||
| WithSpec(rayv1ac.RayJobSpec(). | |||
| WithSubmissionMode(rayv1.HTTPMode). | |||
| WithEntrypoint("python /home/ray/jobs/fail.py"). | |||
| WithEntrypointNumCpus(2). | |||
There was a problem hiding this comment.
How about simply updating "Successful RayJob" and leave other tests the same?
…_num_cpus, entrypoint_num_gpus and entrypoint_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Continue the #1893, this PR completes the lightweight job submission by adding supports of
entrypoint_num_cpus,entrypoint_num_gpus, andentrypoint_resourcesparameters while generating submission requests.I also corrected the type of
RayJobRequest.Resourcestomap[string]float32as suggested in the ray source: https://github.com/ray-project/ray/blob/cfbf98c315cfb2710c56039a3c96477d196de049/dashboard/modules/job/common.py#L353Checks