[Refactor] Rewrite RayCluster envtest #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
changed the title
|
cc @rueian for review |
|
cc @andrewsykim for the RayCluster suspend. |
jjyao
approved these changes
Feb 28, 2024
|
@rueian @andrewsykim I will merge this PR without your review to unblock my release process. If you have any comments, I will address them in the follow-up PRs. |
Sorry for the late reply, LGTM! |
|
LGTM too! |
ravishtiwari
pushed a commit
to ravishtiwari/kuberay
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
All tests in envtest couple together. This PR separates the old tests into 3 categories, autoscaling, static, and suspend. After this PR is merged, I will work on some tests for multi-host.
Related issue number
Checks