Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kind version. #1957

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

vinayakankugoyal
Copy link
Contributor

@vinayakankugoyal vinayakankugoyal commented Mar 1, 2024

Why are these changes needed?

We are using a very old version of kind in our testing this is causing us to pull a very old image of kind nodes and test against a really old version of kubernetes. Logs below are from [Compatibility Test - Nightly](https://github.com/ray-project/kuberay/actions/runs/8104366012/job/22151018968?pr=1955#logs)

2024-03-01:00:17:27,958 INFO     [utils.py:356] Execute command: kind create cluster --wait 900s --config /home/runner/work/kuberay/kuberay/tests/framework/config/kind-config.yaml
Creating cluster "kind" ...
 β€’ Ensuring node image (kindest/node:v1.21.1) πŸ–Ό  ...
 βœ“ Ensuring node image (kindest/node:v1.21.1) πŸ–Ό
 β€’ Preparing nodes πŸ“¦   ...
 βœ“ Preparing nodes πŸ“¦ 
 β€’ Writing configuration πŸ“œ  ...
 βœ“ Writing configuration πŸ“œ
 β€’ Starting control-plane πŸ•ΉοΈ  ...
 βœ“ Starting control-plane πŸ•ΉοΈ
 β€’ Installing CNI πŸ”Œ  ...
 βœ“ Installing CNI πŸ”Œ
 β€’ Installing StorageClass πŸ’Ύ  ...
 βœ“ Installing StorageClass πŸ’Ύ
 β€’ Waiting ≀ 15m0s for control-plane = Ready ⏳  ...
 βœ“ Waiting ≀ 15m0s for control-plane = Ready ⏳
 β€’ Ready after 24s πŸ’š

Related issue number

#1935
Closes #1314

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
    • CI tests are passing. This change only affects CI config.

Signed-off-by: Vinayak Goyal <vinaygo@google.com>
@vinayakankugoyal
Copy link
Contributor Author

Now the tests are pulling a much newer version of kubernetes.

2024-03-01:01:22:41,667 INFO     [utils.py:356] Execute command: kind create cluster --wait 900s --config /home/runner/work/kuberay/kuberay/tests/framework/config/kind-config.yaml
Creating cluster "kind" ...
 β€’ Ensuring node image (kindest/node:v1.29.2) πŸ–Ό  ...
 βœ“ Ensuring node image (kindest/node:v1.29.2) πŸ–Ό
 β€’ Preparing nodes πŸ“¦   ...
 βœ“ Preparing nodes πŸ“¦ 
 β€’ Writing configuration πŸ“œ  ...
 βœ“ Writing configuration πŸ“œ
 β€’ Starting control-plane πŸ•ΉοΈ  ...
 βœ“ Starting control-plane πŸ•ΉοΈ
 β€’ Installing CNI πŸ”Œ  ...
 βœ“ Installing CNI πŸ”Œ
 β€’ Installing StorageClass πŸ’Ύ  ...
 βœ“ Installing StorageClass πŸ’Ύ
 β€’ Waiting ≀ 15m0s for control-plane = Ready ⏳  ...
 βœ“ Waiting ≀ 15m0s for control-plane = Ready ⏳
 β€’ Ready after 17s πŸ’š

@vinayakankugoyal
Copy link
Contributor Author

/retest

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to update the version in the operator e2e tests GH actions workflow too.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the issue with our Buildkite CI has already been fixed. #1314

@kevin85421 kevin85421 self-assigned this Mar 1, 2024
@kevin85421 kevin85421 merged commit bab00be into ray-project:master Mar 1, 2024
23 checks passed
ravishtiwari pushed a commit to ravishtiwari/kuberay that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Upgrade kind version to latest
3 participants