Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v4 TPU manifests samples #1968

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conversation

richardsliu
Copy link
Contributor

Updates TPU v4 sample manifests for Kuberay v1.1

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind renaming the file name from ray-cluster-tpu-v4-multihost.yaml to ray-cluster.tpu-v4-multihost.yaml and ray-cluster-tpu-v4-singlehost.yaml to ray-cluster.tpu-v4-singlehost.yaml

@kevin85421 kevin85421 self-assigned this Mar 7, 2024
@richardsliu
Copy link
Contributor Author

@kevin85421 All done, please take a look.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing the CI errors related to RayCluster? You can run the tests locally by following https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#running-configuration-tests-locally.

@richardsliu
Copy link
Contributor Author

Fixed the broken tests.

@kevin85421 kevin85421 merged commit e6722b0 into ray-project:master Mar 7, 2024
23 checks passed
richardsliu added a commit to richardsliu/kuberay that referenced this pull request Mar 7, 2024
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants