[RayService] Address Recent Flakiness in RayService Zero Downtime Rollout Test #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Yicheng-Lu-llll
commented
Mar 9, 2024
| @@ -76,7 +76,7 @@ def __init__( | |||
| self, | |||
| custom_resource_object, | |||
| rulesets: List[RuleSet] = [], | |||
| timeout: int = 90, | |||
| timeout: int = 180, | |||
There was a problem hiding this comment.
We now need to wait for the old RayCluster to be deleted if switching the RayCluster. The old RayCluster will only be deleted 60 seconds after it becomes inactive. Therefore, we need at least 90 + 60 = 150 seconds; the extra 30 seconds are for the overhead and safety.
|
I have triggered the CI test 5 times, and the RayService test has passed every time. The RayService Zero Downtime Rollout Test seems stable now. Note, the failed CI tests are RayCluster tests, which are unrelated to this PR. |
kevin85421
approved these changes
Mar 12, 2024
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Recently, RayService zero downtime rollout test becomes flaky:
#1837 describes the root cause and introduces a hotfix.
My previous pr #1928 attempts to address the issue and remove the hotfix but as shown avoce, it actually fails to resolve them.
This PR introduces logic to ensure that, for zero-downtime rollout tests, during the period when the serve service has not been fully updated and the old RayCluster has not been deleted,
RayServiceUpdateCREventexpects the query request to be processed by either the old or the new RayCluster.Related issue number
Checks