[RayService] fix kubebuilder printcolumn annotations for RayService #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
|
@kevin85421 PTAL |
andrewsykim
changed the title
kevin85421
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Nice! cc @Yicheng-Lu-llll would you mind taking a look? Thanks!
|
lgtm! I also tested manually. |
Yicheng-Lu-llll
approved these changes
Mar 11, 2024
|
Should we cherry-pick this into the release v1.1 branch? |
|
I will cherry-pick every commit that is not already on the v1.1.0 branch to v1.1.0. |
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Mar 15, 2024
…ay-project#1981) Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
kevin85421
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current print coloumns for RayService are not being rendered, this is because they were added to the wrong type.
This PR fixes the kubebuilder annotation and adds another coloumn for "NUM SERVE ENDPOINTS"
Related issue number
Checks