ray-operator: parameterize Test_ShouldDeletePod #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin85421 / @architkulkarni could you PTAL whenever you get a chance, thanks! |
kevin85421
reviewed
Mar 15, 2024
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
ray-operator/controllers/ray/raycluster_controller_fake_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
MadhavJivrajani
force-pushed
the
parameterize-test
branch
from
feea539
to
8a9627b
Compare
|
Thanks for the comments @kevin85421! I've addressed them. |
kevin85421
approved these changes
Mar 17, 2024
kevin85421
pushed a commit
to kevin85421/kuberay
that referenced
this pull request
Mar 22, 2024
kevin85421
added a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Parameterizing
Test_ShouldDeletePodfollowing the review comment here: #1386 (review)Also I'm assuming #1392 talks about
Test_ShouldDeletePodand notTest_RunningPods_RayContainerTerminated? Lmk!Related issue number
Fixes #1392
Checks