[Telemetry] KubeRay version and CRD #2024
Conversation
| @@ -629,6 +629,13 @@ func setContainerEnvVars(pod *corev1.Pod, rayNodeType rayv1.RayNodeType, rayStar | |||
| usageEnv := corev1.EnvVar{Name: utils.RAY_USAGE_STATS_KUBERAY_IN_USE, Value: "1"} | |||
| container.Env = append(container.Env, usageEnv) | |||
| } | |||
| if rayNodeType == rayv1.HeadNode { | |||
| extraTagsEnv := corev1.EnvVar{ | |||
| Name: utils.RAY_USAGE_STATS_EXTRA_TAGS, | |||
There was a problem hiding this comment.
Do we need to inject this env var to worker nodes? @jjyao
| @@ -37,11 +37,8 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| _version_ = "0.2" | |||
There was a problem hiding this comment.
The changes in this file are unrelated to the telemetry. I simply deleted some unused code.
| if rayNodeType == rayv1.HeadNode { | ||
| extraTagsEnv := corev1.EnvVar{ | ||
| Name: utils.RAY_USAGE_STATS_EXTRA_TAGS, | ||
| Value: fmt.Sprintf("kuberay_version=%s,crd=%s", utils.KUBERAY_VERSION, string(creatorCRDType)), |
There was a problem hiding this comment.
Let's make the key kuberay_version and kuberay_crd
| @@ -167,6 +168,9 @@ const ( | |||
|
|
|||
| // RayNodeHeadGroupLabelValue is the value for the RayNodeGroupLabelKey label on a head node | |||
| RayNodeHeadGroupLabelValue = "headgroup" | |||
|
|
|||
| // Telemetry | |||
| KUBERAY_VERSION = "nightly" | |||
There was a problem hiding this comment.
@kevin85421 since this is defined as a constant, it will always be nightly instead of the actual kuberay version. Is that expected or am I missing something?
There was a problem hiding this comment.
I opened a PR to the release branch to update it #2036.
There was a problem hiding this comment.
Ah, gotcha. I opeend #2042 to also include this constant in the user-agent
It's a minor change, no need to cherry-pick to 1.1
Why are these changes needed?
Related issue number
Checks