Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding label check #221

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

akanso
Copy link
Collaborator

@akanso akanso commented Apr 4, 2022

Why are these changes needed?

We need to use the utils.CheckLabel() function when creating a K8s service

Related issue number

#220

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@akanso akanso self-assigned this Apr 4, 2022
@akanso akanso requested a review from Jeffwan April 4, 2022 19:11
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Jeffwan Jeffwan merged commit 2beb34c into ray-project:master Apr 5, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Co-authored-by: Ali Kanso <ali.kanso@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants