Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress not found errors into regular logs #222

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

akanso
Copy link
Collaborator

@akanso akanso commented Apr 6, 2022

Why are these changes needed?

A not found error in the context of a delete or update operation is possible if the user for example deletes the RayCluster while the operator is trying to update it.

This PR suppresses those errors and only logs them

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@akanso akanso self-assigned this Apr 6, 2022
@akanso akanso requested a review from Jeffwan April 6, 2022 16:24
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable and looks good to me.

@Jeffwan Jeffwan merged commit c22f2ae into ray-project:master Apr 11, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* adding label check

* suppress not found error

Co-authored-by: Ali Kanso <ali.kanso@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants