Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace scope for Ray cluster get and delete operations #229

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

daikeshi
Copy link
Contributor

@daikeshi daikeshi commented Apr 14, 2022

Why are these changes needed?

This PR added namespaced operations to get and delete a Ray cluster via KubeRay API server and CLI

Related issue number

Closes #209

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@daikeshi daikeshi changed the title Add namespace scope for get and delete Ray cluster operations Add namespace scope for Ray cluster get and delete operations Apr 14, 2022
@daikeshi daikeshi force-pushed the master branch 2 times, most recently from a09b322 to c60ff44 Compare April 17, 2022 03:02
@daikeshi daikeshi marked this pull request as ready for review April 17, 2022 03:11
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks for the contribution!

@Jeffwan Jeffwan merged commit 94fd314 into ray-project:master Apr 20, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…oject#229)

* Update proto to add namespace

* Add namespace scope support to api server

* Add namespace scope support to cli

* Add default namespace for get and delete ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Namespaced Operation Support
2 participants