-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]Run kuberay in a single namespace #258
[Feature]Run kuberay in a single namespace #258
Conversation
Let's have a discussion tomorrow on this. |
553f9ee
to
e9ebf8b
Compare
now we use kustomize to patch clusterrole clusterrolebinding with a very minimal code change. cc @Jeffwan |
bases: | ||
- ../../base | ||
patches: | ||
- path: patch-cr.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the name? Will we have cluster-role
created in namespace scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will convert all cluster-role to role with namespace.
BTW, This is kind of tricky. Besides Kind itself, we need to make sure apiversion is correct as well. There might be other issues like CRB doesn't have namespace field but RB does. I think it's still acceptable at this moment. Let's do the refactor later if it lack of flexibility in the future. |
I guess an admin may be the one to run the first step. A user with restricted permissions would run the second step. |
e9ebf8b
to
784ab7e
Compare
yes, I should make this more clear. I updated the README document |
804c4a5
to
8947ea4
Compare
use kustomize patch to update cluster level role and rolebinding to using a single namespace
8947ea4
to
25e76fd
Compare
25e76fd
to
c3fd348
Compare
* single namespace support use kustomize patch to update cluster level role and rolebinding to using a single namespace * bug fix * bug fix: watch namespace * bug fix * bug fix * bug fix
Why are these changes needed?
Run kuberay in a single namespace.
Instead of setup kuberay using
now we use
Related issue number
#227
Checks