[hotfix] Fix Service account typo

[DmitriGekhtman]

Why are these changes needed?

Fixes a typo in the operator's role that prevents it from managing service accounts, which in turn blocks setup of autoscaling Ray clusters.

TODO: How to test??

Related issue number

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[DmitriGekhtman]

I'd propose banning the plural in English.
Definitely unnecessary.

[brucez-anyscale]

why do we need this change? serviceaccount should be correct.

[brucez-anyscale]

If we need serviceaccount, we should update code

kuberay/ray-operator/controllers/ray/raycluster_controller.go

Line 77 in 7ecdd22

// +kubebuilder:rbac:groups=core,resources=serviceaccount,verbs=get;list;watch;create;delete

kuberay/ray-operator/controllers/ray/rayservice_controller.go

Line 48 in 7ecdd22

// +kubebuilder:rbac:groups=core,resources=serviceaccount,verbs=get;list;watch;create;delete

Change serviceaccount to serviceaccounts and make manifest to auto generate role.yaml

[DmitriGekhtman]

It turns out the plural form is the correct way to specify the resource name (compare to "pods" and "services" elsewhere in this file).
With "serviceaccount" (singular) it fails to grant the necessary permissions (which are used only to set up the autoscaler's service account)

[DmitriGekhtman]

If we need serviceaccount, we should update code

Thanks for pointing that out!! Will do.

[DmitriGekhtman]

One apple, ten apple.

[brucez-anyscale]

Thanks for fixing this typo.