Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoscaler debug example to prevent confusion #326

Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jun 28, 2022

Why are these changes needed?

To prevent confusion in #325 and let's remove the example.

Related issue number

#325

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan Jeffwan changed the title Remove autoscaler debug example Remove autoscaler debug example to prevent confusion Jun 28, 2022
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DmitriGekhtman DmitriGekhtman merged commit 4f96425 into ray-project:master Jun 28, 2022
@Jeffwan Jeffwan deleted the remove_misleading_example branch June 29, 2022 01:04
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
To prevent confusion in ray-project#325 and let's remove the example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants