fix: typo worker_group_sepc -> worker_group_spec #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @scarlet25151 Since you make the changes in downstream version already, please help review the change |
scarlet25151
reviewed
Jul 4, 2022
There was a problem hiding this comment.
@davidxia I notice that there is some other places that have same typo
apiserver/pkg/manager/resource_manager.go:L93
apiserver/pkg/util/cluster.go:L45
apiserver/pkg/server/cluster_server.go:L127
cli/pkg/cmd/cluster/create.go:L142
apiserver/pkg/model/converter.go:L35
that part need to be modified to be compatible with the proto changes.
|
@scarlet25151 thanks, I think I replaced all of them now. |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks