use more strict formatting #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonwang371
force-pushed
the
wilson/strict-formatting
branch
from
33cef71
to
50e8402
Compare
| //key, _ := cmd.Flags().GetString("key") | ||
| //value, _ := cmd.Flags().GetString("value") | ||
| // key, _ := cmd.Flags().GetString("key") | ||
| // value, _ := cmd.Flags().GetString("value") |
DmitriGekhtman
approved these changes
Jul 18, 2022
|
@wilsonwang371 |
wilsonwang371
force-pushed
the
wilson/strict-formatting
branch
from
50e8402
to
6808902
Compare
|
|
||
| - name: Open this to see how to fix gofumpt if it fails | ||
| run: | | ||
| echo "Run command 'gofumpt -w apiserver/ ray-operator/ cli/' to correct your code format." |
There was a problem hiding this comment.
nit: will this check correct the import format? for example:
https://github.com/ray-project/kuberay/blob/master/ray-operator/controllers/ray/raycluster_controller.go#L3-L37
import (
"context"
"fmt"
"strings"
"time"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"github.com/ray-project/kuberay/ray-operator/controllers/ray/common"
"github.com/ray-project/kuberay/ray-operator/controllers/ray/utils"
rbacv1 "k8s.io/api/rbac/v1"
rayiov1alpha1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1alpha1"
"k8s.io/client-go/tools/record"
"github.com/go-logr/logr"
_ "k8s.io/api/apps/v1beta1"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
networkingv1 "k8s.io/api/networking/v1"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
controller "sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
)would need some format
There was a problem hiding this comment.
it will check the imports but the code you show will pass the check.
There was a problem hiding this comment.
got it, it seems like some codes writing practice issues and gofumpt may not correct them, in this case we may need to modify manually.
wilsonwang371
force-pushed
the
wilson/strict-formatting
branch
2 times, most recently
from
ef505c7
to
1f876b2
Compare
|
@wilsonwang371 Let's rebase the change and we can unblock the PR. |
wilsonwang371
force-pushed
the
wilson/strict-formatting
branch
from
1f876b2
to
69a58e7
Compare
Jeffwan
approved these changes
Jul 20, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* use more strict formatting * rebase master * update makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Use a more strict format check with gofumpt
We discussed this a long time before. Due to some conflicts with our internal branch, we postponed this until now. Since our downstream branch and upstream branch is in sync now, it is a good time for us to apply a more strict code formatting on kuberay.
Related issue number
N/A
Checks