tune readiness probe timeouts #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonwang371
force-pushed
the
wilson/tune-probe-timeouts
branch
5 times, most recently
from
0f84c84
to
577850d
Compare
wilsonwang371
changed the title
wilsonwang371
requested review from
Jeffwan,
scarlet25151,
brucez-anyscale,
DmitriGekhtman and
fishbone
|
I have run this test consecutively more than 3 times and didn't experience failures anymore. |
Jeffwan
reviewed
Jul 26, 2022
| @@ -73,15 +73,15 @@ const ( | |||
| LOCAL_HOST = "127.0.0.1" | |||
| // Ray HA default readiness probe values | |||
| DefaultReadinessProbeInitialDelaySeconds = 10 | |||
| DefaultReadinessProbeTimeoutSeconds = 0 | |||
| DefaultReadinessProbePeriodSeconds = 0 | |||
| DefaultReadinessProbeTimeoutSeconds = 1 | |||
There was a problem hiding this comment.
/cc @iycheng @brucez-anyscale
wilsonwang371
force-pushed
the
wilson/tune-probe-timeouts
branch
from
577850d
to
402fc06
Compare
fishbone
approved these changes
Jul 26, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* tune readiness probe timeouts * increase wait time after kubectl apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Timeout values in Github workflow Kind environment is not long enough for ray serve tests.
Related issue number
#406
Checks