Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostPathType and mountPropagationMode field for apiserver #413

Merged

Conversation

scarlet25151
Copy link
Collaborator

Why are these changes needed?

In some case, the user would like to indicate more beyond the volume type, for example user may would like to mount the file and indicate the hostpath type to file, the apiserver need to transfer this information.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@scarlet25151 scarlet25151 self-assigned this Jul 25, 2022
@scarlet25151 scarlet25151 added enhancement New feature or request apiserver labels Jul 25, 2022
@scarlet25151
Copy link
Collaborator Author

/cc @Jeffwan for not bringing the breaking change, I add a new additional field hostPathType, PTAL.

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful and we can unblock the full mount capabilities.

@Jeffwan Jeffwan merged commit 0417d38 into ray-project:master Jul 26, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Co-authored-by: chenyu.jiang <chenyu.jiang@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apiserver enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants