Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve compatibility test stability #418

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

wilsonwang371
Copy link
Collaborator

@wilsonwang371 wilsonwang371 commented Jul 26, 2022

Why are these changes needed?

Sometimes the base compatibility test can fail. This might be related to exceptions not being handled correctly.

Related issue number

#294

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 26, 2022

@wilsonwang371 Can we create an issue to discuss ray version coverage?

I feel we can remove 1.9, 1.10, 1.11 and add 1.13?

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 26, 2022

@wilsonwang371 Not sure if 1.13 works or not.. it runs ~1h
image

@wilsonwang371
Copy link
Collaborator Author

@wilsonwang371 Not sure if 1.13 works or not.. it runs ~1h
image

i am waiting for the log to debug

@wilsonwang371
Copy link
Collaborator Author

@wilsonwang371 Not sure if 1.13 works or not.. it runs ~1h image

This is due to 1.13.0 does not have redis python package installed. I corrected this part.

@wilsonwang371 wilsonwang371 changed the title [WIP]improve compatibility test stability improve compatibility test stability Jul 26, 2022
@Jeffwan Jeffwan merged commit f39c255 into ray-project:master Jul 27, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* increase wait time after kubectl apply

* remove earlier version of ray from compatibility test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants