Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose swallowed detail error messages #422

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jul 27, 2022

Why are these changes needed?

image

Current response doesn't give any detail clues on the failure

image

Detail logs are swallowed due to previous GetStatus change. I add them back now.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@wilsonwang371
Copy link
Collaborator

lgtm

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 27, 2022

image

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 27, 2022

It looks good now and I will merge it

@Jeffwan Jeffwan merged commit 9bb690e into ray-project:master Jul 27, 2022
@Jeffwan Jeffwan deleted the jiaxin/imporve_logs branch July 27, 2022 23:33
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants