Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new 8000 port forwarding in kind #424

Merged

Conversation

wilsonwang371
Copy link
Collaborator

Why are these changes needed?

add 8000 port forwarding in kind and avoid using kubectl port-forward

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@wilsonwang371 wilsonwang371 changed the title add new 8000 port forwarding in kind [WIP]add new 8000 port forwarding in kind Jul 27, 2022
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 27, 2022

Is this an improvement to replace kubectl proxy-forward or it's also for test enhancement? Does the 8000 not reachable issues come from port-forward or not?

@wilsonwang371
Copy link
Collaborator Author

Is this an improvement to replace kubectl proxy-forward or it's also for test enhancement? Does the 8000 not reachable issues come from port-forward or not?

From what we have seen, kubectl port forwarding is not very stable. So instead, we use kind config to setup port forwarding. So far it looks like running fine. I am just running it one more time to confirm it is working.

@wilsonwang371 wilsonwang371 changed the title [WIP]add new 8000 port forwarding in kind add new 8000 port forwarding in kind Jul 28, 2022
@Jeffwan Jeffwan merged commit 6a938e0 into ray-project:master Jul 28, 2022
Copy link
Contributor

@brucez-anyscale brucez-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants