Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rayservice] Fix config names to match serve config format directly #464

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[rayservice] Fix config names to match serve config format directly #464

merged 1 commit into from
Aug 12, 2022

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Aug 11, 2022

Why are these changes needed?

Renames the config fields to match more directly:

  • serveDeploymentGraphConfig -> serveConfig
  • serveConfigs -> deployments

We should also make the fields support snake_case so that they can be copy-pasted directly from serve build, but that would be a larger change.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@simon-mo
Copy link
Collaborator

@Jeffwan FYI can we pick this into 0.3 release? Thanks

@DmitriGekhtman
Copy link
Collaborator

This seems good to merge -- feel free to do that.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 12, 2022

@Jeffwan FYI can we pick this into 0.3 release? Thanks

Sure. I will help cherry-pick the change to release-0.3 branch

@Jeffwan Jeffwan merged commit c25d95c into master Aug 12, 2022
@Jeffwan Jeffwan deleted the eoakes/rename-serve-configs branch August 12, 2022 00:15
davidxia pushed a commit to davidxia/kuberay that referenced this pull request Aug 12, 2022
@edoakes @davidxia
[rayservice] Fix config names to match serve config format directly (r…
46c641a 
…ay-project#464)
DmitriGekhtman pushed a commit to DmitriGekhtman/kuberay that referenced this pull request Aug 15, 2022
@edoakes @DmitriGekhtman
[rayservice] Fix config names to match serve config format directly (r…
6c94f30 
…ay-project#464)
@DmitriGekhtman DmitriGekhtman mentioned this pull request Aug 15, 2022
Merged
DmitriGekhtman added a commit that referenced this pull request Aug 16, 2022
@DmitriGekhtman
[rayservice] Fix config names to match serve config format directly (#…
ac710f5 
…464) (#477)

Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>

This picks #464 into the KubeRay 0.3.0 branch.
That PR changed the names of some config fields to match Ray Serve's API.
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@edoakes
[rayservice] Fix config names to match serve config format directly (r…
ef7a549 
…ay-project#464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

Assignees

@simon-mo simon-mo

@DmitriGekhtman DmitriGekhtman

@brucez-anyscale brucez-anyscale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@edoakes @simon-mo @DmitriGekhtman @Jeffwan @shrekris-anyscale @brucez-anyscale