Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm instructions: kubectl apply -> kubectl create #505

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

DmitriGekhtman
Copy link
Collaborator

Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com

Why are these changes needed?

Fixes another apply crd.yaml to read create crd.yaml.
See #271.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
@DmitriGekhtman
Copy link
Collaborator Author

The nightly compatibility test appears to still be a bit flakey.
On a related note, we should add Ray 2.0.0 to the compatibility matrix.
cc @wilsonwang371

@DmitriGekhtman DmitriGekhtman changed the title Helm instructions: kubectl create -> kubectl apply Helm instructions: kubectl apply -> kubectl create Aug 26, 2022
@wilsonwang371
Copy link
Collaborator

i will add Ray 2.0 in the compatibility test and reorg the tests.

@Jeffwan Jeffwan merged commit 3438b3e into ray-project:master Aug 26, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* kubectl create

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

* wip

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>

* Rerun CI.

Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants