refactor: log more descriptive info from initContainer #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the example workers' initContainer that checks for head Pod to be running logs the message `waiting for myservice`. There is no `myservice` per se. The actual thing it's waiting for is the K8s Service for the head group. This change updates the log message to be more descriptive and removes the string `myservice` from various places to not be misleading.
|
Sorry for taking long on this change. Let me help review it |
|
Thanks, it's pretty small. Just the same change in many different files. Lmk if you have any questions. |
Signed-off-by: David Xia <davidxia@users.noreply.github.com>
DmitriGekhtman
approved these changes
Nov 30, 2022
|
This looks good to me. Apologies for the nearly three month delay in review. I'll merge after re-running the failed test. In the future, I propose having the operator auto-configure an initContainer which will health-check the Ray head pod's GCS server: #476 |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Right now the example workers' initContainer that checks for head Pod to be running logs the message `waiting for myservice`. There is no `myservice` per se. The actual thing it's waiting for is the K8s Service for the head group. This change updates the log message to be more descriptive and removes the string `myservice` from various places to not be misleading. Signed-off-by: David Xia <davidxia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the example workers' initContainer that checks for
head Pod to be running logs the message
waiting for myservice.There is no
myserviceper se. The actual thing it's waiting foris the K8s Service for the head group.
This change updates the log message to be more descriptive and
removes the string
myservicefrom various places to not be misleading.Checks