Update Helm doc. #531
Merged
Update Helm doc. #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com>
|
cc @asm582 |
kevin85421
approved these changes
Sep 5, 2022
|
@kevin85421 even better, let's host the charts at a helm repo! |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Signed-off-by: Dmitri Gekhtman <dmitri.m.gekhtman@gmail.com> This PR removes the reference to KubeRay 0.4.0 in the Helm documentation. There's a comment indicating that the command to download an install the charts won't work until KubeRay 0.4.0. However, some users may miss the comment and attempt to run the command. We can re-introduce the command to the documentation when we release KubeRay 0.4.0. This PR also updates the description of Ray to match the current description in the Ray repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman dmitri.m.gekhtman@gmail.com
Why are these changes needed?
This PR removes the reference to KubeRay 0.4.0 in the Helm documentation.
There's a comment indicating that the command to download an install the charts won't work until KubeRay 0.4.0.
However, some users may miss the comment and attempt to run the command.
We can re-introduce the command to the documentation when we release KubeRay 0.4.0.
This PR also updates the description of Ray to match the current description in the Ray repo.
Related issue number
Checks