[Feature] Add helm lint check in Github Actions #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
force-pushed
the
helm-lint
branch
from
b50502d
to
63859dd
Compare
4 tasks
|
TODO: pre-push hook |
|
This is great. It would be great if you can add few sentences in development guidance and people will know how to fix the problem if they encouter the CI issue |
Jeffwan
approved these changes
Sep 13, 2022
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Adds a helm lint check to verify that charts are well-formed and properly formatted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In #537 and #499, there are some errors that only happen in old helm versions. Hence, if we add helm lint check with multiple helm versions in GitHub Actions, we can avoid #537 and #499.
#537 and #499 only happen in old helm versions as mentioned in #548. Hence, we run helm lint tests for both Helm v3.4.1 and v3.9.4.
The modifications in
ray-cluster/values.yamlare detected by this PR as shown in the following link and screenshot.Related issue number
Closes #550
Checks
I used #555 as a control group. This PR tried to reproduce #537. Hence, the test with helm v3.4 should fail and test with helm v3.9 should pass in #555. The error message is the same as #537. See the link and following screenshot for more details.